Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DeserializedResponses parameter for gateway in booster-http #1531

Closed
dirkmc opened this issue Jun 20, 2023 · 1 comment
Closed

Use DeserializedResponses parameter for gateway in booster-http #1531

dirkmc opened this issue Jun 20, 2023 · 1 comment
Assignees

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Jun 20, 2023

Depends on #1492

With the release of boxo v0.10.1, the config for the Boxo Gateway handler config now has variable called DeserializedResponses.
When set to true, flat files (i.e. deserialized responses) are served, as all CAR and RAW files.
When set to false, flat files are not served, and the only CAR + RAW files served are those that can verify trustlessly (all CAR requests and RAW requests that have no path).

booster-http contains a significant amount of code aimed at partially replicating this behavior. However the Boxo code is more correct. Boost filters by file type, which serves some requests that cannot be verified trustlessly (RAW blocks served at a path are not verifiable)

We should switch booster-http to take advantage of the new parameter:

  • Remove --serve-files, --serve-blocks and --serve-cars parameters
  • Add parameter --serve-gateway=verifiable|all|none
    • verifiable: set DeserializedResponses to false
    • all: set DeserializedResponses to true
    • none: do not enable gateway handler
@dirkmc dirkmc changed the title Use Deserializedr boxo parameters in booster-http Use DeserializedResponses parameter for gateway in booster-http Jun 20, 2023
@alvin-reyes alvin-reyes self-assigned this Aug 15, 2023
@LexLuthr
Copy link
Collaborator

Resolved by Frisbii implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants