Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for FIP-0090/0092 #457

Closed
4 tasks done
BigLep opened this issue Jun 11, 2024 · 6 comments
Closed
4 tasks done

Release for FIP-0090/0092 #457

BigLep opened this issue Jun 11, 2024 · 6 comments
Assignees

Comments

@BigLep
Copy link
Member

BigLep commented Jun 11, 2024

Tracking issue for doing a filecoin-ffi release for FIP-0090/0092 in support of nv23.

This will follow this process: https://github.com/filecoin-project/filecoin-ffi?tab=readme-ov-file#development-guidelines-wip

Depends on

  1. vmx
  2. rvagg
  3. rvagg
  4. vmx
@rjan90
Copy link
Contributor

rjan90 commented Jun 14, 2024

I have published a filecoin-ffi dev-release (v1.28.0-dev2) based on the latest commit in PR #459. The last commit in that PR patches rust-fil-proofs to #1758, unblocking testing in Butterfly until a proper rust-fil-proofs release is available.

@BigLep
Copy link
Member Author

BigLep commented Jun 21, 2024

It looks like we have the rust-fil-proofs release per filecoin-project/rust-fil-proofs#1758 thus should be able to close this one out.

@BigLep
Copy link
Member Author

BigLep commented Jun 24, 2024

Marking as done/closed since @rjan90 had marked it as such in https://docs.google.com/document/d/1MOHg6HoFzqKP3EZ_ptBL9sOht0AP8cnYoWFkmRH5MZo/edit

@BigLep BigLep closed this as completed Jun 24, 2024
@BigLep BigLep reopened this Jun 24, 2024
@BigLep
Copy link
Member Author

BigLep commented Jun 24, 2024

2024-06-24 conversation: reopened because we want to have a filecoin-ffi dev-release (v1.28.0-rc1) with the release that corresponds with filecoin-project/rust-fil-proofs#1758

@rjan90
Copy link
Contributor

rjan90 commented Jun 24, 2024

2024-06-24 conversation: reopened because we want to have a filecoin-ffi dev-release (v1.28.0-rc1) with the release that corresponds with filecoin-project/rust-fil-proofs#1758

Hey! I should have updated this issue ticket before I went OOO. But the filecoin-ffi release (v1.28.0-rc1) includes an update to rust-fil-proofs 18.1 in this commit 3bca86b which is a patch release that includes filecoin-project/rust-fil-proofs#1758.

Therefore there should not be a need of cutting another filecoin-ffi release, unless there has been other breaking changes since I went OOO.

@BigLep
Copy link
Member Author

BigLep commented Jun 24, 2024

Thanks @rjan90 - I should have looked at the source. Good to know we're good to go here. Closing!

@BigLep BigLep closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants