Ni-PoRep Go/cgo additions #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rvagg
force-pushed
the
rvagg/niporep
branch
3 times, most recently
from
88ce5b8
to
0035005
Compare
rvagg
commented
May 29, 2024
rvagg
force-pushed
the
rvagg/niporep
branch
2 times, most recently
from
0226a23
to
dadbf5d
Compare
Closed
Stebalien
approved these changes
Jun 13, 2024
go.mod
Outdated
| @@ -5,7 +5,7 @@ go 1.18 | |||
| require ( | |||
| github.com/filecoin-project/go-address v1.1.0 | |||
| github.com/filecoin-project/go-fil-commcid v0.1.0 | |||
| github.com/filecoin-project/go-state-types v0.13.1 | |||
| github.com/filecoin-project/go-state-types v0.14.0-dev.0.20240611104512-19a29aa50e4a | |||
There was a problem hiding this comment.
I'd cut a release if we're ready.
There was a problem hiding this comment.
Agreed, it was just waiting for approval but I've given it a tick so @rjan90 can move forward there.
There was a problem hiding this comment.
Updated to go-state-types v0.14.0-rc1 in: ca67564
|
Got something funky going on with the gocheck2 .. on aarch it wants it as a GOEXPERIMENT=gocheck2, but Darwin and Linux builders don't recognise that. I'll have to figure that one out before this can be landed. |
|
Specifically:
??? |
|
Ah: the aarch64 runner is "ubuntu-2204:current" while the others are |
Update GST to v0.14.0-rc1
Upgrade the golang executor to use Go 1.21
vmx
added a commit
that referenced
this pull request
Jun 13, 2024
This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458.
vmx
added a commit
that referenced
this pull request
Jun 13, 2024
This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458.
|
I'm closing given superseded by #459 |
vmx
added a commit
that referenced
this pull request
Jun 18, 2024
* feat: add support for Non-interactive PoRep This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458. --------- Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: nemo <nemo@ellipticresearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional changes on top of a rebased #453, while I try and wire things up for integration testing.This has local linking for ref-fvm for filecoin-project/ref-fvm#1999 on top of master for filecoin-project/ref-fvm#2009.It also has local linking for rust-filecoin-proofs-api for filecoin-project/rust-filecoin-proofs-api#103--
Additions on top of #453, but this depends on filecoin-project/go-state-types#269 being merged.
Note that his also includes
seal_commit_phase2_circuit_proofsinrust/src/proofs/api.rs, that could go into #453.