feat: reduce default oct rows to discard from 3 to 2 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we can do what we need to do without touching merkle_light, by just not using the default method here, and instead having our own default method in rust-fil-proofs (that uses the settings, etc) |
porcuquine
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
I am approving this as the expedient way to change the default as desired for a short-term release. However, I think longer-term this default should not be set here. The 'right' default is dependent on usage and may change for reasons unrelated to the merkle_light implementation. (For example, if/when we optimize regenerating bottom tree segments, discarding more may make sense.)
|
Closing in favor of filecoin-project/rust-fil-proofs#1165 |
This was referenced Jul 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.