-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non Interactive Proof of Replication #1999
Conversation
shared/src/sector/seal.rs
Outdated
pub proof: Vec<u8>, | ||
pub sealed_cid: Cid, // Commr | ||
pub unsealed_cid: Cid, // Commd | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this without introducing a new NISealVerifyInfo type, and thus without a new syscall at all? The proof type carries the information that it is NI, and then determines that certain fields will be ignored.
- deal_ids: already ignored and always empty
- interactive_randomness: let's just specify it shall be zero (and ignored) for NI proofs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was my initial thinking too. Will change that.
This is probably ready for review. We'll need it to land so the actors change can depend on it. @Stebalien the associated FIP is accepted. Can we land this direct to master? |
It looks like this doesn't build with the "proofs" feature enabled. |
just needs the additional |
True, but I need to change dependancy to the |
A new Filecoin-proofs-api release is expected to be out today (Thursday May 16th), which includes the NI-PoRep registered proofs. |
It looks like |
Can we close this, since its superseded by #2010? |
Yes. |
No description provided.