Skip to content

Commit

Permalink
fix: cli: make the default value of clap args work properly (#1590)
Browse files Browse the repository at this point in the history
remove `required(true)` if default value exists
  • Loading branch information
0x5459 committed Apr 25, 2022
1 parent 075a545 commit f3cde0e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions fil-proofs-tooling/src/bin/benchy/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ fn main() -> Result<()> {
.arg(
Arg::new("api_version")
.long("api-version")
.required(true)
.help("The api_version to use (default: 1.1.0)")
.default_value("1.1.0")
.takes_value(true),
Expand All @@ -108,7 +107,6 @@ fn main() -> Result<()> {
.arg(
Arg::new("api_version")
.long("api-version")
.required(true)
.help("The api_version to use (default: 1.1.0)")
.default_value("1.1.0")
.takes_value(true),
Expand All @@ -132,7 +130,6 @@ fn main() -> Result<()> {
.arg(
Arg::new("api_version")
.long("api-version")
.required(true)
.help("The api_version to use (default: 1.1.0)")
.default_value("1.1.0")
.takes_value(true),
Expand Down
3 changes: 0 additions & 3 deletions fil-proofs-tooling/src/bin/update_tree_r_cache/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ fn main() -> Result<()> {
.about("Rebuild tree_r_last trees from replica")
.arg(
Arg::new("size")
.required(true)
.long("size")
.default_value("34359738368")
.help("The data size in bytes")
Expand All @@ -342,7 +341,6 @@ fn main() -> Result<()> {
.about("Inspect tree_r_last trees and match with p_aux in cache")
.arg(
Arg::new("size")
.required(true)
.long("size")
.default_value("34359738368")
.help("The data size in bytes")
Expand All @@ -367,7 +365,6 @@ fn main() -> Result<()> {
.about("Verify tree_r_last trees and check for cache mis-match")
.arg(
Arg::new("size")
.required(true)
.long("size")
.default_value("34359738368")
.help("The data size in bytes")
Expand Down

0 comments on commit f3cde0e

Please sign in to comment.