Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Piece writes more than needed #1372

Open
ortyomka opened this issue Nov 20, 2020 · 0 comments
Open

Add Piece writes more than needed #1372

ortyomka opened this issue Nov 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ortyomka
Copy link

Description

If we transfer a file with size N to add_piece and ask to write M bytes (where N > M)

Then the function will write N bytes. It seems like overkill.

I think add_piece should write M bytes only

Acceptance criteria

add_piece function writes piece_size bytes

Risks + pitfalls

If you pass /dev/zero file, then the copy will be infinite.

Where to begin

Here

@cryptonemo cryptonemo added the enhancement New feature or request label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants