fix: verify consistent use of porep_id when sealing #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
force-pushed
the
feat/enforce-consistent-porep-id
branch
from
d1f6c86
to
02e1a84
Compare
dignifiedquire
previously approved these changes
Jun 16, 2020
dignifiedquire
previously approved these changes
Jun 16, 2020
cryptonemo
previously approved these changes
Jun 16, 2020
porcuquine
dismissed stale reviews from cryptonemo and dignifiedquire
via
83a0515
porcuquine
force-pushed
the
feat/enforce-consistent-porep-id
branch
from
f7066c7
to
83a0515
Compare
cryptonemo
approved these changes
Jun 16, 2020
dignifiedquire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
porep_idin generatingreplica_id, when deriving drg seed, and when deriving feistel keys are independent. This PR adds a check to ensure they are consistent. Currentfilecoin_proofsAPI function will always pass the correctporep_idobtained from thePoRepConfigand therefore be 'consistent'. The checks inserted here ensure this is true.UPDATE: In fact,
porep_idstill being a public input was a vestige of its evolution and no longer required. So consistency is produced even more simply by removing it altogether.