opt: Stacked DRG: swap buffers instead of memcpy #1197 #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyvank
requested review from
cryptonemo,
dignifiedquire and
porcuquine
as code owners
cryptonemo
previously approved these changes
Jul 2, 2020
porcuquine
previously approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Nice, looks good!
I pushed a commit I think clarifies the meaning of these buffers and will help minimize confusion for future readers. This was a little easier than trying to explain my hope. If you accept these changes, I think this is good to go (after rebase).
|
@porcuquine LGTM |
cryptonemo
previously approved these changes
Jul 6, 2020
porcuquine
previously approved these changes
Jul 8, 2020
|
Needs rebase. |
cryptonemo
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1197