fix: correct rows_to_discard value during post #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires filecoin-project/merkletree#89 |
|
Related to #1219 |
porcuquine
previously approved these changes
Jul 17, 2020
|
@porcuquine Can you take a look at filecoin-project/merkletree#89 as well? I think the proper way to proceed is to merge that one first, cut a new release for merkle_light, then update this PR to point to that new version. Separately, we can decide if we need to cut an unplanned proofs release today. I'm inclined to say no since I have a handle on the issue and it's inefficient, but not breaking as-is, and I'm not entirely sure users of |
|
Yep, I'm looking and have on question (will ask there). I think it's fine to defer releasing this until the next natural release. |
|
Resolves #1219 |
porcuquine
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.