feat: add a check parameter command that maps parameter files #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #1235 |
vmx
previously approved these changes
Aug 4, 2020
cryptonemo
force-pushed
the
check-parameters
branch
from
76cecb4
to
cca27e3
Compare
vmx
approved these changes
Aug 5, 2020
I figured it could someday be used for more than mapping, maybe verifying, or dumping info about, etc. Not urgent right now, but might be nice to have a tool that can do some more checking on parameters as needed. |
|
I'll merge this after #1235 btw. @porcuquine should still review/approve. |
|
I'd merge this right away once @porcuquine reviewed it. It's independent of #1235. I'd merge #1235 after #1242/#1244 so that @DrPeterVanNostrand doesn't have to rebase. |
porcuquine
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.