Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fil-blst usage in Window PoSt possible #1272

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Sep 4, 2020

This PR consists of three parts:

  • fil-blst based verification to Window PoSt.
  • Logging so that you can easily verify when fil-blst is used.
  • a new CI job is added to run the tests that use the flt-blst code path with use_fil_blst enabled.

On the CI logs you can see that fil_blst was used (search for use_fil_blst=true).

This feature can be enabled with the `use_fil_blst` setting.
Ideally the tests with fil-blst enabled can be run without any special
flags, but for now it's good enough to run them on CI.
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes. @cryptonemo I think once this merges, we can create another release. That will then contain all the verification optimizations we can provide directly from rust-fil-proofs.

@porcuquine porcuquine merged commit 909b19a into master Sep 4, 2020
@porcuquine porcuquine deleted the blst-window-post branch September 4, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants