chore: destructure settings in settings bin #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
previously approved these changes
Sep 10, 2020
Improve the code of the `settings` tool. Now the settings are destructured, this way whenever a new setting will be introduce there will be a compile error.
vmx
force-pushed
the
destructure-settings-bin
branch
from
238a24a
to
812bef6
Compare
|
I just did a clean rebase. This is ready to be merged. |
cryptonemo
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the code of the
settingstool. Now the settings are destructured,this way whenever a new setting will be introduce there will be a compile
error.
Those are the things to be done while waiting for CI.