Optimize Phase1. #1289
Merged
Optimize Phase1. #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
force-pushed
the
opt/sdr-phase1
branch
from
2755c2c
to
21e4820
Compare
porcuquine
commented
Sep 25, 2020
porcuquine
force-pushed
the
opt/sdr-phase1
branch
from
db08d49
to
155fc31
Compare
cryptonemo
reviewed
Sep 25, 2020
cryptonemo
reviewed
Sep 25, 2020
cryptonemo
reviewed
Sep 25, 2020
porcuquine
force-pushed
the
opt/sdr-phase1
branch
from
1c52ea5
to
fc78c04
Compare
porcuquine
force-pushed
the
opt/sdr-phase1
branch
from
fc78c04
to
0313c66
Compare
porcuquine
commented
Sep 25, 2020
| std::slice::from_raw_parts_mut((*self.bufs.get()).as_mut_ptr(), 2) | ||
| } | ||
|
|
||
| // TODO: is this actually needed? |
There was a problem hiding this comment.
It's not currently used. It was split into the start and finish portions and split across layer-transition boundaries. I think it remains useful documentation of intent. It could probably be refactored into a call to start then finish, which would serve that purpose even better.
dignifiedquire
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Sealing optimizations but needs a little more cleanup.
@dignifiedquire An early step in this was simplification of the previous sealing (an intentional regression to facilitate moving forward). Now that we have decided to retain previous behavior and make the optimizations (initially) opt-in, some work is required to restore the previous behavior. I started in on this, but it's incomplete, as you will see.
If you have some time and the will to do it, you could reenable the previous behavior. The setting-based selection is implemented, but the
generate_labelscode path now calls the simplified, intermediate code. Instead, it should call the previous code — which is deleted in this PR's first commit. Once that is restored, this work will be almost done.