fix: fix log message #1312
Merged
fix: fix log message #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
requested review from
cryptonemo,
dignifiedquire and
porcuquine
as code owners
cryptonemo
previously approved these changes
Oct 12, 2020
dignifiedquire
previously approved these changes
Oct 12, 2020
|
Please someone else merge this. I don't want to trigger any rebasing nightmares. I guess @cryptonemo knows best when to merge :) |
I think the main (current) conflict might be #1305, so let's see where that's at today to decide order. I don't anticipate this being a major rebase hassle either way though. |
The log message was wrong. It's about the hash of the concatenated `comm_c` and `comm_r_last`. This was brought up at #1308 (comment)
vmx
force-pushed
the
fix-wrong-log-message
branch
from
7c3f84d
to
f53e5f4
Compare
cryptonemo
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log message was wrong. It's about the hash of the concatenated
comm_candcomm_r_last.This was brought up at
#1308 (comment)
For the notation I used
||for concatenation as in the comment above.I don't know about notations for hashes. I'm more familiar with
++or.as concatenationoperator (in programming languages).