Remove Mutex from settings #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
requested review from
cryptonemo and
dignifiedquire
as code owners
porcuquine
force-pushed
the
settings-no-mutex
branch
from
bad7d37
to
a1ed593
Compare
cryptonemo
approved these changes
Oct 19, 2020
dignifiedquire
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings don't need to be protected by a Mutex. Apart from being unnecessary, this also led to a recent difficult-to-debug problem when the Mutex was mistakenly held too long in a draft of #1305. (This forced independent threads to work sequentially, eliminating the benefits of parallelism.) We should avoid making it easy to accidentally introduce such performance degradations, especially since they could go unnoticed if not specifically being looked for.