refactor: remove unused pedersen hasher #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
requested review from
cryptonemo and
porcuquine
as code owners
porcuquine
reviewed
Oct 26, 2020
| // kdf_constraints | ||
| // merkle_tree_datahash_constraints - sha2 constraints 64 | ||
| // merkle_tree_hash_constraints - 64 byte pedersen | ||
| } |
There was a problem hiding this comment.
Shouldn't these all be replaced with poseidon, rather than simply removed?
There was a problem hiding this comment.
seems like these comments are not really used anymore anyway
There was a problem hiding this comment.
Maybe kill them all then?
porcuquine
previously approved these changes
Oct 26, 2020
cryptonemo
previously approved these changes
Oct 27, 2020
dignifiedquire
dismissed stale reviews from cryptonemo and porcuquine
via
a95ab89
dignifiedquire
force-pushed
the
refactor-remove-pedersen
branch
from
a95ab89
to
98f0647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.