filecoin-proofs re-organization #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filecoin-proofs/src/fr32.rs
Outdated
| @@ -855,179 +855,3 @@ where | |||
|
|
|||
| Ok(raw_data.len()) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
lets keep these tests in here, they are quite simple and unity
filecoin-proofs/tests/constants.rs
Outdated
| use filecoin_proofs::with_shape; | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
no need for this #[cfg(test)]; mod tests in the tests directory
filecoin-proofs/tests/parameters.rs
Outdated
| use filecoin_proofs::parameters::{select_challenges, winning_post_public_params}; | ||
| use filecoin_proofs::types::{PoStConfig, PoStType}; | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
these are very simple unit level tests, lets keep them where they were
fil-proofs-param/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| storage-proofs = { path = "../storage-proofs", default-features = false } | ||
| filecoin-proofs = { path = "../filecoin-proofs", default-features = false } |
There was a problem hiding this comment.
these should have a version too
|
there are a bunch of tests for the binaries in |
refactor: move circuit info to fil-proofs -tooling
cryptonemo
force-pushed
the
fp-organize
branch
from
e1a766d
to
9cf3bef
Compare
cryptonemo
changed the title
dignifiedquire
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.