fix: put checkout_cores test behind a single-threaded feature #1383
Conversation
cryptonemo
requested review from
dignifiedquire and
porcuquine
as code owners
.circleci/config.yml
Outdated
| @@ -147,6 +147,7 @@ jobs: | |||
| ulimit -u 20000 | |||
| ulimit -n 20000 | |||
| cargo +<< pipeline.parameters.nightly-toolchain >> -Zpackage-features test --all --verbose --release lifecycle -- --ignored --nocapture | |||
| cargo +<< pipeline.parameters.nightly-toolchain >> -Zpackage-features test --features single-threaded --release checkout_cores -- --test-threads=1 | |||
There was a problem hiding this comment.
this is missing the --all package specifier
There was a problem hiding this comment.
Correct, that's the purpose of this PR. The all is performed, followed by the single checkout_cores test that is isolated.
There was a problem hiding this comment.
but it still needs to select a package?
There was a problem hiding this comment.
The CI log shows what I see locally, which is the single test running (after the all): https://app.circleci.com/pipelines/github/filecoin-project/rust-fil-proofs/2838/workflows/c44d3b1c-e69e-43cc-8c06-6c4e533ccf92/jobs/62773
There was a problem hiding this comment.
Ok, adding the package is more direct, I'll change that (just tried locally).
|
Currently, the sdr checkout test is done on the pairing side and not mirrored on the blst side. I don't think there's any need to run it more than once. Should it be moved out to a separate job entirely? I only really want to know if it's failing for some reason on CI. |
feat: add checkout_cores test to CI, run single threaded doc: fix typo
cryptonemo
force-pushed
the
update-checkout-core
branch
from
3e86037
to
554a404
Compare
feat: add checkout_cores test to CI, run single threaded
doc: fix typo
A possible way to address #1378