perf(storage-proofs-post): increase parallelism in fallback-post #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
requested review from
cryptonemo and
porcuquine
as code owners
cryptonemo
approved these changes
Dec 3, 2020
|
thanks to @robyhugeman666 for reminding me that we can do more here |
|
Very honored to be involved.
…------------------------------------------------------------------
From:Friedel Ziegelmayer <notifications@github.com>
Send Time:2020年12月3日(星期四) 23:34
To:filecoin-project/rust-fil-proofs <rust-fil-proofs@noreply.github.com>
Cc:robyhugeman666 <robyhugeman@aliyun.com>; Mention <mention@noreply.github.com>
Subject:Re: [filecoin-project/rust-fil-proofs] perf(storage-proofs-post): increase parallelism in fallback-post (#1384)
thanks to @robyhugeman666 for reminding me that we can do more here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
free1139
reviewed
Dec 5, 2020
| |all_valid, is_valid| Ok(all_valid? && is_valid?), | ||
| )?; | ||
| if !is_valid { | ||
| return Ok(false); |
There was a problem hiding this comment.
@dignifiedquire we also need continue the check and record the fault sectors here to skip them. I had lost the storage power cause some sectors failed in here, but i forgot the detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the parallelism during both vanilla
proveand vanillaverify.