feat: update sha2-asm dependency version #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update call based on updated version
cryptonemo
commented
May 6, 2021
sha2raw/src/platform.rs
Outdated
| @@ -81,7 +81,7 @@ impl Implementation { | |||
| for block in blocks.chunks(2) { | |||
| buffer[..32].copy_from_slice(&block[0]); | |||
| buffer[32..].copy_from_slice(&block[1]); | |||
| sha2_asm::compress256(state, &buffer); | |||
| sha2_asm::compress256(state, &vec![buffer]); | |||
There was a problem hiding this comment.
@dignifiedquire What's the better non-allocating way to do this?
There was a problem hiding this comment.
Hah! Nevermind, clippy for the win
There was a problem hiding this comment.
Also, I thought that's what I first tried, but apparently not ...
dignifiedquire
approved these changes
May 6, 2021
This was referenced May 6, 2021
neithanmo
pushed a commit
to Zondax/rust-fil-proofs
that referenced
this pull request
Jun 9, 2021
* feat: update sha2-asm dependency version * fix: update call based on updated version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update call based on updated version