feat: add a srs key loading bench #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: separate aggregation benches from preprocessing
cryptonemo
force-pushed
the
aggregation-benches
branch
from
31d287d
to
4d9a054
Compare
filecoin-proofs/tests/api.rs
Outdated
| #[test] | ||
| fn test_aggregate_proof_encode_decode() -> Result<()> { | ||
| // This byte vector is a natively serialized aggregate proof. | ||
| let aggregate_proof_bytes = vec
There was a problem hiding this comment.
probably better to put into its own file and use include_bytes!
| assert_eq!(aggregate_proof_bytes, aggregate_proof_bytes2.as_slice()); | ||
|
|
||
| // Note: the native serialization format is more compact than bincode serialization, so assert that here. | ||
| let bincode_serialized_proof = serialize(&aggregate_proof)?; |
There was a problem hiding this comment.
lets actually weite the numbers as constants in here as well
| porep_id, | ||
| api_version: ApiVersion::V1_1_0, | ||
| }; | ||
| let comm_r: [u8; 32] = [5u8; 32]; |
There was a problem hiding this comment.
no need to specify the type
fix: apply review feedback
|
what's the state here? |
Needs review/approval |
dignifiedquire
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: separate aggregation benches from preprocessing