fix: properly implement and document cuda feature #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
reviewed
Sep 29, 2021
| When the library is built with both CUDA and OpenCL support, you can choose which one to use at run time. Use the environment variable: | ||
|
|
||
| ``` | ||
| FIL_PROOFS_GPU_FRAMEWORK=cuda |
There was a problem hiding this comment.
Setting this value on master currently appears to do nothing -- opencl is used in all cases for me unless I specify --features cuda on the command line
There was a problem hiding this comment.
Yes, it's part of this PR.
cryptonemo
reviewed
Sep 29, 2021
|
|
||
| `FIL_PROOFS_CUDA_NVCC_ARGS="--fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75"` | ||
|
|
||
| Note that this environment variable is forwarded to underlying dependencies, which might not be automatically be rebuilt. If you change this variable, best is to start from a clean build. |
There was a problem hiding this comment.
Following cargo clean, running FIL_PROOFS_GPU_FRAMEWORK=opencl cargo test --release --all --features cuda,opencl -- --nocapture --ignored used cuda. Is this expected?
UPDATE: setting BELLMAN_GPU_FRAMEWORK=opencl and NEPTUNE_GPU_FRAMEWORK=opencl does run opencl if added to the above
10 tasks
It's possible to compile rust-fil-proofs to make it run on CUDA instead of OpenCL. This change also includes the introduction of two new environment variables. One to control, whether OpenCL or CUDA should be used. The other to tweak `nvcc` options.
|
Rebased and tested locally -- this works for me. I'll approve if CI is happy. |
cryptonemo
approved these changes
Sep 29, 2021
|
@vmx please delete the branch when you're ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to compile rust-fil-proofs to make it run on CUDA instead
of OpenCL. This change also includes the introduction of two new environment
variables. One to control, whether OpenCL or CUDA should be used. The other
to tweak
nvccoptions.