Poseidon version of SnapDeals

[Kubuxu]

Signed-off-by: Jakub Sztandera kubuxu@protocol.ai

[DrPeterVanNostrand]

Thanks for writing this! Looks good to me.

A couple of comments/questions:

• It looks like this is a single partition circuit, am I correct in thinking that?
• I think that restructuring this module makes sense when the vanilla side is built (mostly Merkle tree/proof shape changes) after the trusted-setup is run, e.g. maybe splitting the empty_sector_update crate into two modules sha and poseidon (which signify TreeD's hasher and shape).

[Kubuxu]

t looks like this is a single partition circuit, am I correct in thinking that?

Yes, it is a single partition.

I think that restructuring this module makes sense when the vanilla side is built (mostly Merkle tree/proof shape changes) after the trusted-setup is run, e.g. maybe splitting the empty_sector_update crate into two modules sha and poseidon (which signify TreeD's hasher and shape).

Agreed, I wanted to limit changes to SHA version that is why I moved new vanilla definitions to the circuit module itself and avoided touching the SHA sides in general where possible.

[DrPeterVanNostrand]

Looks good to me. Thanks!

[cryptonemo]

@Kubuxu Can we get this rebased against latest so that it can have final review before merge?

[BlocksOnAChain]

@Kubuxu @DrPeterVanNostrand @cryptonemo - Just wanted to say I'm glad we got this one in the scope. Great idea and all the work behind it. 🎉 👍