fix: SDR: make it possible to bind to cores if units > groups #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
requested review from
dignifiedquire,
cryptonemo and
DrPeterVanNostrand
as code owners
vmx
commented
Apr 22, 2022
| @@ -157,7 +157,7 @@ jobs: | |||
| ulimit -u 20000 | |||
| ulimit -n 20000 | |||
| cargo test --all --verbose --release lifecycle -- --ignored --nocapture | |||
| cargo test -p storage-proofs-porep --features isolated-testing --release checkout_cores -- --test-threads=1 | |||
| cargo test -p storage-proofs-porep --features isolated-testing --release --lib stacked::vanilla::cores | |||
There was a problem hiding this comment.
In case you are wondering about this change. It still runs the original and now two additional tests. And the --test-threads=1 is already set by the RUST_TEST_THREADS: 1 below (you need to click once on expanding the source file).
dignifiedquire
previously approved these changes
Apr 23, 2022
vmx
force-pushed
the
many-group-sdr
branch
2 times, most recently
from
0990379
to
fab7903
Compare
For multicore SDR it is important that the producer and conumers share the same (L3) cache. Hence we bind specific cores to threads. Prior to this change there was one multicore SDR job per group, even if the group could accompany multiple of such jobs. If there were more jobs scheduled than groups available, those additional jobs wouldn't use specific cores, but whatever the operating system decided. With this change, additional jobs are now put into the groups in case there is enough space to accompany them. Fixes #1556.
|
This was just a rebase without code changes. When it get re-approved it get be merged :) |
cryptonemo
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multicore SDR it is important that the producer and conumers share the
same (L3) cache. Hence we bind specific cores to threads. Prior to this
change there was one multicore SDR job per group, even if the group could
accompany multiple of such jobs. If there were more jobs scheduled than
groups available, those additional jobs wouldn't use specific cores, but
whatever the operating system decided.
With this change, additional jobs are now put into the groups in case there
is enough space to accompany them.
Fixes #1556.