fix: remove DRG PoRep #1684
Merged
fix: remove DRG PoRep #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPeterVanNostrand
previously approved these changes
May 16, 2023
There was a problem hiding this comment.
I'm happy with removing DRG-PoRep. I think that it still exists mainly for posterity's sake. A more minimal change would be to enable it with a feature flag (off by default); but either are fine with me. And as you said, if for some reason DRG-PoRep needs to be referenced in the future, it will always exist in git history.
cryptonemo
previously approved these changes
Jun 13, 2023
The DRG PoRep was never used, hence remove it as it is only maintenance burden without adding any value.
cryptonemo
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DRG PoRep was never used, hence remove it as it is only maintenance burden without adding any value.