Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clarify h and h_select #1696

Merged
merged 2 commits into from
May 17, 2023
Merged

refactor: clarify h and h_select #1696

merged 2 commits into from
May 17, 2023

Commits on May 16, 2023

  1. refactor: clarify h and h_select 

    The circuit supports a fixed hard-coded list of `h` values (7-12). Those
values are addressed by their index in the list. It can be seen as a 6-bit
bit-pattern, which is called `h_select`.

The vanilla proof also supports that list of `h` values.

The proofs APIs use a fixed value, 1 for sector sizes <= 32KiB and 10 for
bigger sector sizes.

All this should make the code more consistent and easier to follow.

BREAKING CHANGE: `hs` and `HSelect` are not longer part of the
`filecoin-proofs` public API.
    @vmx
    vmx committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d990742 View commit details
    Browse the repository at this point in the history

  2. refactor: rename num_high_bits to h_default 

    It's a better name.
    @vmx
    vmx committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ea9eb65 View commit details
    Browse the repository at this point in the history