refactor: replicate_phase2 needs cache dir only #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing a whole config, which is then modified later on, just pass in the cache directory, which is the only thing that is used from the config. This change make it more obvious which values are actually modified.
DrPeterVanNostrand
approved these changes
May 16, 2023
There was a problem hiding this comment.
Looks good to me, but @cryptonemo probably should also approve prior to merging.
cryptonemo
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing a whole config, which is then modified later on, just pass in the cache directory, which is the only thing that is used from the config. This change make it more obvious which values are actually modified.