Cleanup code a bit #1719
Merged
Cleanup code a bit #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is only a single PoRep, remove the unnecessary trait abstraction.
The `transform_and_replicate_layers()` function is only used in tests, hence move it there.
This commit removes a no longer used function and refactors some code to contain less mutability in a more Rust idiomatic way.
The prodbench wasn't run in years and isn't really maintained, it was only update if there were compiler warnings. Remove it to reduce maintenance burden.
Some code was presumably commented out accidentally is commented in again.
vmx
force-pushed
the
cleanup-code-202309
branch
from
c7fe0a3
to
300ad5f
Compare
cryptonemo
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various cleanups that are made to make the implementation of a version that doesn't need a persisted
t_auxfile easier.This PR is reviewed easiest when each commit is reviewed individually.