fix: simpler cache cleaning #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring `t_aux` for cache cleaning, use file name globbing. This is less code and easier to document and reason about.
vmx
force-pushed
the
cleanup-cache-with-glob
branch
from
e3778d9
to
3ad86a9
Compare
cryptonemo
reviewed
Oct 12, 2023
| @@ -25,6 +26,7 @@ pub use challenges::{ | |||
| synthetic::SYNTHETIC_POREP_VANILLA_PROOFS_EXT, synthetic::SYNTHETIC_POREP_VANILLA_PROOFS_KEY, | |||
| ChallengeRequirements, LayerChallenges, SynthChallenges, | |||
| }; | |||
| pub use clear_files::{clear_cache_dir, clear_synthetic_proofs}; | |||
There was a problem hiding this comment.
Why am I not seeing clear_layer_data (the exposed API)?
There was a problem hiding this comment.
cryptonemo
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring
t_auxfor cache cleaning, use file name globbing. This is less code and easier to document and reason about.