refactor: Challenges enum #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
reviewed
Dec 4, 2023
|
I've pushed a new version without the testing code changes, which shows again that splitting PRs into small independent pieces is the way to go (which I also should've done here). |
Reducing the public API where it's not needed. Currently is `SynthChallenges` not used outside this crate, hence make it non-public. This enables later refactors, where the struct can be renamed.
Renaming the `SynthChallenges` struct int `SynthChallengeGenerator` in order to make clear that those are not the actual challenges, but that it's an object to generate challenges.
The `Challenges` enum introduces a bit more type safety.
cryptonemo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for the non-interactive PoRep, where a new type of challenges will be introduced.
Though it also makes sense outside of this. A new
Challengesenum is introduced, which add a bit more type safety. This way you cannot accidentally use e.g. the interactive PoRep challenges with the synthetic PoRep.For more consistency the
SynthChallengesstruct renamed toSynthChallengeGenerator, so that we can have aSynthChallengesstruct which corresponds to theInteractiveChallengesand upcomingNiChallengesstruct.For testing purpose it's now possible to add any feature (not just the Synthetic PoRep one). This is something that is needed for the NonInteractive PoRep, as well as the Resnaps work.
I've keep the individual commits for easier reviewing, the major change is the
introduce Challenges enumcommit.