fix: remove wrong assert in Synth PoRep code path #1750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to me understanding the code wrongly during the refactoring at #1720, there was a wrong assert inserted into the code. With removing this assert the lifecycle 32GiB test as well as the benchy synthetic proofs generation works as expected again. This commit also updates the README with the correct command to run benchy for synthetic proofs generation. Fixes #1749.
DrPeterVanNostrand
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Looks good to me, just with the caveat that this change is included in #1748.
|
The fix was merged with #1748. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to me understanding the code wrongly during the refactoring at #1720, there was a wrong assert inserted into the code. With removing this assert the lifecycle 32GiB test as well as the benchy synthetic proofs generation works as expected again.
This commit also updates the README with the correct command to run benchy for synthetic proofs generation.
Fixes #1749.