-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update FIP92 min value to proposed new value #1758
Conversation
feat: add negative bounds checking test feat: add a 32GiB max value ni-porep aggregation test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in draft, but it looks good to me.
@vmx : if @cryptonemo is out this week, can you please take on merging? Also, (newbie question) are there any followup steps needed for releasing this change? |
@BigLep I could merge, but @cryptonemo needs to do a release in order to be picked up by the FFI. So I leave it open as a reminder, so that he can do a release when he's back. |
@vmx : thanks! Just to make sure I'm following, in order to be able to start Butterfly testing we need to:
If that sequence above is correct, doing the rust-fil-proofs release will be blocking right? So that @rjan90 can start Butterly testing the EU morning of Monday, 2024-06-17, can rust-fil-proofs be released before end of the week (EOD 2024-06-14)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fwiw
Nope, this has to wait till 2024-06-18 when @cryptonemo is available again. |
@cryptonemo : are you able to merge and release now? |
feat: add negative bounds checking test
feat: add a 32GiB max value ni-porep aggregation test
In case this is needed in reference to filecoin-project/FIPs#1018