Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update FIP92 min value to proposed new value #1758

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

cryptonemo
Copy link
Collaborator

feat: add negative bounds checking test
feat: add a 32GiB max value ni-porep aggregation test

In case this is needed in reference to filecoin-project/FIPs#1018

feat: add negative bounds checking test
feat: add a 32GiB max value ni-porep aggregation test
vmx
vmx previously approved these changes Jun 5, 2024
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in draft, but it looks good to me.

@cryptonemo cryptonemo changed the title feat: update FIP90 min value to proposed new value feat: update FIP92 min value to proposed new value Jun 6, 2024
@BigLep
Copy link
Member

BigLep commented Jun 13, 2024

@vmx : if @cryptonemo is out this week, can you please take on merging? Also, (newbie question) are there any followup steps needed for releasing this change?

@vmx
Copy link
Contributor

vmx commented Jun 13, 2024

@BigLep I could merge, but @cryptonemo needs to do a release in order to be picked up by the FFI. So I leave it open as a reminder, so that he can do a release when he's back.

@BigLep
Copy link
Member

BigLep commented Jun 13, 2024

@vmx : thanks! Just to make sure I'm following, in order to be able to start Butterfly testing we need to:

  1. merge this PR
  2. do a release of rust-fil-proofs
  3. update feat: add support for Non-interactive PoRep filecoin-ffi#459 with the rust-fil-proofs release so it can be merged
  4. do a filecoin-ffi release
    ... (not sure of other steps - I don't think critical for this conversation)
  5. update Lotus

If that sequence above is correct, doing the rust-fil-proofs release will be blocking right? So that @rjan90 can start Butterly testing the EU morning of Monday, 2024-06-17, can rust-fil-proofs be released before end of the week (EOD 2024-06-14)?

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fwiw

@vmx
Copy link
Contributor

vmx commented Jun 14, 2024

can rust-fil-proofs be released before end of the week (EOD 2024-06-14)?

Nope, this has to wait till 2024-06-18 when @cryptonemo is available again.

@BigLep
Copy link
Member

BigLep commented Jun 17, 2024

@cryptonemo : are you able to merge and release now?

@cryptonemo cryptonemo merged commit 855ff3b into master Jun 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants