Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attributes in references #2

Open
finestructure opened this issue Mar 6, 2020 · 2 comments
Open

Support attributes in references #2

finestructure opened this issue Mar 6, 2020 · 2 comments

Comments

@finestructure
Copy link
Owner

![An "Arena Gala" on iPad][image-1]

[image-1]:	https://f000.backblazeb2.com/file/finestructure-public-images/posts/arena-gala-on-ipad.png width=954

renders as

<img src=​"https:​/​/​f000.backblazeb2.com/​file/​finestructure-public-images/​posts/​arena-gala-on-ipad.png width=954" alt=​"An " arena gala" on ipad">​
@finestructure
Copy link
Owner Author

finestructure commented Mar 6, 2020

Edit: the whitespace is not the issue, that fact that it's a reference link it.

NB: This might include several separate problem: the whitespace in the caption, the quotes, and the fact that the "width=954" is tacked on to the end of the footnote instead of being inline with the link.

@finestructure
Copy link
Owner Author

It doesn't look like there's a sane way to fix this. Inside the modifier handler imageAttributes() we've only got

(lldb) po html
"<img src=\"https://foo.com/image.png width=954\" alt=\"An \"Arena Gala\" on iPad\"/>"

(lldb) po markdown
"![An \"Arena Gala\" on iPad][image-1]"

So we can't reparse the markdown because it doesn't include the reference. And parsing the html instead is a bad idea(tm).

@finestructure finestructure changed the title Support titles with whitespace Support attributes in references Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant