From e8b15c0416ca534c941ed35fea0c975c8153aa18 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Fri, 19 Jan 2024 15:10:53 -0500 Subject: [PATCH 1/2] copy code changes from https://github.com/firebase/firebase-js-sdk/pull/7963 so the github actions can be run by a contributor --- packages/util/src/environment.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/util/src/environment.ts b/packages/util/src/environment.ts index 04bbd92165d..9e54d228125 100644 --- a/packages/util/src/environment.ts +++ b/packages/util/src/environment.ts @@ -138,6 +138,7 @@ export function isNodeSdk(): boolean { export function isSafari(): boolean { return ( !isNode() && + navigator.userAgent && navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('Chrome') ); From 8c7a241e318e49f0f79bd56e12fe682fd71bb764 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Fri, 19 Jan 2024 15:16:02 -0500 Subject: [PATCH 2/2] use !! to coerce navigator.userAgent to a boolean --- packages/util/src/environment.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/util/src/environment.ts b/packages/util/src/environment.ts index 9e54d228125..f2afaede0f1 100644 --- a/packages/util/src/environment.ts +++ b/packages/util/src/environment.ts @@ -138,7 +138,7 @@ export function isNodeSdk(): boolean { export function isSafari(): boolean { return ( !isNode() && - navigator.userAgent && + !!navigator.userAgent && navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('Chrome') );