From f83698fe275a2991b1de1d820f85263c16750bc4 Mon Sep 17 00:00:00 2001
From: Daniel La Rocque <dlarocque@google.com>
Date: Thu, 26 Sep 2024 12:30:09 -0400
Subject: [PATCH] Remove data-connect es5 bundles

---
 packages/data-connect/package.json     |  4 +-
 packages/data-connect/rollup.config.js | 62 +++++++-------------------
 2 files changed, 17 insertions(+), 49 deletions(-)

diff --git a/packages/data-connect/package.json b/packages/data-connect/package.json
index ba697fb9a76..0a2502e4045 100644
--- a/packages/data-connect/package.json
+++ b/packages/data-connect/package.json
@@ -6,7 +6,6 @@
   "main": "dist/index.node.cjs.js",
   "browser": "dist/index.esm2017.js",
   "module": "dist/index.esm2017.js",
-  "esm5": "dist/index.esm5.js",
   "exports": {
     ".": {
       "types": "./dist/public.d.ts",
@@ -14,7 +13,6 @@
         "import": "./dist/node-esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
-      "esm5": "./dist/index.esm5.js",
       "browser": {
         "require": "./dist/index.cjs.js",
         "import": "./dist/index.esm2017.js"
@@ -77,4 +75,4 @@
     ],
     "reportDir": "./coverage/node"
   }
-}
\ No newline at end of file
+}
diff --git a/packages/data-connect/rollup.config.js b/packages/data-connect/rollup.config.js
index cb220911d69..72d1660c5a9 100644
--- a/packages/data-connect/rollup.config.js
+++ b/packages/data-connect/rollup.config.js
@@ -35,47 +35,15 @@ function onWarn(warning, defaultWarn) {
   defaultWarn(warning);
 }
 
-const es5BuildPlugins = [
+const buildPlugins = [
   typescriptPlugin({
     typescript,
     abortOnError: false
   }),
-  json()
-];
-
-const es2017BuildPlugins = [
-  typescriptPlugin({
-    typescript,
-    tsconfigOverride: {
-      compilerOptions: {
-        target: 'es2017'
-      }
-    },
-    abortOnError: false
-  }),
   json({ preferConst: true })
 ];
 
 const browserBuilds = [
-  {
-    input: 'src/index.ts',
-    output: [
-      {
-        file: pkg.esm5,
-        format: 'es',
-        sourcemap: true
-      }
-    ],
-    plugins: [
-      ...es5BuildPlugins,
-      replace(generateBuildTargetReplaceConfig('esm', 5))
-    ],
-    treeshake: {
-      moduleSideEffects: false
-    },
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
-    onwarn: onWarn
-  },
   {
     input: 'src/index.ts',
     output: [
@@ -86,7 +54,7 @@ const browserBuilds = [
       }
     ],
     plugins: [
-      ...es2017BuildPlugins,
+      ...buildPlugins,
       replace(generateBuildTargetReplaceConfig('esm', 2017))
     ],
     treeshake: {
@@ -97,15 +65,13 @@ const browserBuilds = [
   },
   {
     input: 'src/index.ts',
-    output: [
-      {
-        file: 'dist/index.cjs.js',
-        format: 'cjs',
-        sourcemap: true
-      }
-    ],
+    output: {
+      file: pkg.exports['.'].browser.require,
+      format: 'cjs',
+      sourcemap: true
+    },
     plugins: [
-      ...es2017BuildPlugins,
+      ...buildPlugins,
       replace(generateBuildTargetReplaceConfig('cjs', 2017))
     ],
     treeshake: {
@@ -119,10 +85,14 @@ const browserBuilds = [
 const nodeBuilds = [
   {
     input: 'src/index.node.ts',
-    output: { file: pkg.main, format: 'cjs', sourcemap: true },
+    output: {
+      file: pkg.main,
+      format: 'cjs', 
+      sourcemap: true 
+    },
     plugins: [
-      ...es5BuildPlugins,
-      replace(generateBuildTargetReplaceConfig('cjs', 5))
+      ...buildPlugins,
+      replace(generateBuildTargetReplaceConfig('cjs', 2017))
     ],
     treeshake: {
       moduleSideEffects: false
@@ -138,7 +108,7 @@ const nodeBuilds = [
       sourcemap: true
     },
     plugins: [
-      ...es2017BuildPlugins,
+      ...buildPlugins,
       replace(generateBuildTargetReplaceConfig('esm', 2017)),
       emitModulePackageFile()
     ],