Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on subfield to create the base ring in EquiangularPolygons #143

Open
videlec opened this issue Jan 26, 2022 · 1 comment · May be fixed by #145
Open

Do not rely on subfield to create the base ring in EquiangularPolygons #143

videlec opened this issue Jan 26, 2022 · 1 comment · May be fixed by #145
Assignees

Comments

@videlec
Copy link
Collaborator

videlec commented Jan 26, 2022

In order to compute the slopes, instead of going through the minimal polynomial of cosines and sines and call projectivization(cos, sin) we could directly compute the minimal polynomial of the tangent.

Note that the only cases where E._base_ring differs from E._cosines_ring is when N % 4 == 0. In that case [E._cosines_ring:E._base_ring] = 2.

@videlec videlec linked a pull request Feb 3, 2022 that will close this issue
@videlec
Copy link
Collaborator Author

videlec commented Feb 3, 2022

Though the minimal polynomial of tan(pi / N) is not nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant