Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_point_position for Polygon (and not only ConvexPolygon) #93

Closed
videlec opened this issue Jun 29, 2021 · 1 comment · Fixed by #241
Closed

Implement get_point_position for Polygon (and not only ConvexPolygon) #93

videlec opened this issue Jun 29, 2021 · 1 comment · Fixed by #241

Comments

@videlec
Copy link
Collaborator

videlec commented Jun 29, 2021

The method ConvexPolygon.get_point_position returns a relative position of the point with respect to the polygon (eg in the interior, on an edge, at a vertex or outside). It does not exist for Polygon even though it does make sense for them. There should exist a general version for Polygon (probably going through the triangulation of the polygon).

It might also be desirable to promote Polygon to ConvexPolygon in the constructors when the input is indeed convex.

@saraedum
Copy link
Member

saraedum commented Jul 3, 2023

It might also be desirable to promote Polygon to ConvexPolygon in the constructors when the input is indeed convex.

That's been fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants