Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to blackfriday.v2 #6

Open
lrstanley opened this issue Dec 23, 2017 · 4 comments
Open

upgrade to blackfriday.v2 #6

lrstanley opened this issue Dec 23, 2017 · 4 comments

Comments

@lrstanley
Copy link

Not sure if pongo2 is maintained anymore at this point, however the upgrade from blackfriday v1 to v2 is quite simple (rather than MarkdownCommon, you'd use Run). May also suggest pairing it with bluemonday (or at least providing it as an option):

bluemonday.UGCPolicy().SanitizeBytes(blackfriday.Run([]byte("content here")))
@metal3d
Copy link

metal3d commented Feb 10, 2018

I currently have to problem, unable to compile my website.

@metal3d
Copy link

metal3d commented Feb 10, 2018

Note that's not the only fix to do. Some const are not present. The better fix to do is to import "v1" version of blackfriday at this time

@lrstanley
Copy link
Author

Of course there may be other small changes necessary, however this library does not look to rely on any of the old constants from the v1 package. If yours does, this isn't necessarily a concern for pongo2-addons. However, it would be better to version lock to at least something (v1 or v2).

In any case, fairly certain both pongo2 and this repo aren't maintained. I may end up forking this, and splitting off/cleaning up some of the addons (i.e. may it so you don't have to use the markdown library, or the go-humanize library if you don't want to, etc). Wish there were better pongo2 alternatives for Go. Love the django-like syntax. 😭

@ashtonian
Copy link

I need this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants