From 32b5d7ec1b4b1b478684df9bde9109ce3c2cd9b9 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Wed, 12 Apr 2023 11:34:24 +0200 Subject: [PATCH] Fix nil pointer deref during diff attempt Signed-off-by: Hidde Beydals --- internal/controllers/helmrelease_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/controllers/helmrelease_controller.go b/internal/controllers/helmrelease_controller.go index 79da39e8a..fb3dc3ada 100644 --- a/internal/controllers/helmrelease_controller.go +++ b/internal/controllers/helmrelease_controller.go @@ -329,7 +329,7 @@ func (r *HelmReleaseReconciler) reconcileRelease(ctx context.Context, hr, hasNewState := v2.HelmReleaseAttempted(hr, revision, releaseRevision, valuesChecksum) // Run diff against current cluster state. - if !hasNewState { + if !hasNewState && rel != nil { if ok, _ := features.Enabled(features.DetectDrift); ok { differ := diff.NewDiffer(runtimeClient.NewImpersonator( r.Client,