Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can this be configured (e.g. s3 for cache in parameters.yml) and the image version should be specified or pullPolicy: IfNotPresent will mean it never changes #4

Open
violuke opened this issue Sep 14, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@violuke
Copy link

violuke commented Sep 14, 2024

Thanks for the chart. I'm looking forward to trying this out. Just a few initial thoughts. Cheers!

@sadok-f sadok-f added enhancement New feature or request question Further information is requested labels Sep 14, 2024
@sadok-f
Copy link
Member

sadok-f commented Sep 14, 2024

Thank you @violuke for opening this issue.
We're still working on the Helm chart to add options to override the configuration in parameters.yml file, we'll release it soon.
regarding the image version, it is set in Chart.yaml file underappVersion variable, where it gets appended to the repository variable when used in the deployment.yml file.
for each new version, we'll release a new helm-chart as well to update the appVersion and add any changes needed.

for the pullPolicy: IfNotPresent if the current version e.g. flyimg/flyimg:1.4.12 is not in the current node, k8s will download it, otherwise use the existing one.
when we release a new version and the helm chart get updated, k8s will download the new requested version.

I hope I answered your questions :)

@violuke
Copy link
Author

violuke commented Sep 17, 2024

Ah, that makes sense. That's really useful, thank you for the reply 😄

@sadok-f sadok-f mentioned this issue Sep 17, 2024
@sadok-f
Copy link
Member

sadok-f commented Sep 17, 2024

Hi @violuke we actually released a new helm chart version that allow the possibility to overriding the default configuration in parameters.yml file
Can you give it a try?
Any feedback is much appreciated!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

2 participants