Merge pull request #422 from fmonniot/dependabot/cargo/tokio-1.39.3 #933
fmonniotAnnotations
10 warnings
|
this operation has no effect:
tsl_2591/src/lib.rs#L88
warning: this operation has no effect
--> tsl_2591/src/lib.rs:88:15
|
88 | &[(TSL2591_COMMAND_BIT | register) & 0xFF],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(TSL2591_COMMAND_BIT | register)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
this operation has no effect:
tsl_2591/src/lib.rs#L100
warning: this operation has no effect
--> tsl_2591/src/lib.rs:100:15
|
100 | &[(TSL2591_COMMAND_BIT | register) & 0xFF],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(TSL2591_COMMAND_BIT | register)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
tsl_2591/src/lib.rs#L109
warning: this operation has no effect
--> tsl_2591/src/lib.rs:109:23
|
109 | let command = (TSL2591_COMMAND_BIT | address) & 0xFF;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(TSL2591_COMMAND_BIT | address)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
tsl_2591/src/lib.rs#L110
warning: this operation has no effect
--> tsl_2591/src/lib.rs:110:19
|
110 | let val = val & 0xFF;
| ^^^^^^^^^^ help: consider reducing it to: `val`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
unneeded unit return type:
my-home/src/actor/channel.rs#L69
warning: unneeded unit return type
--> my-home/src/actor/channel.rs:69:40
|
69 | type SendMessage<M> = Arc<Box<dyn Fn(M) -> () + Send + Sync>>;
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|
|
unneeded unit return type:
my-home/src/actor/network.rs#L57
warning: unneeded unit return type
--> my-home/src/actor/network.rs:57:68
|
57 | send_packet: Box<dyn Fn(UdpPacketResult<C::Item, C::Error>) -> () + Send + Sync>,
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
|
|
the type of the `self` parameter does not need to be arbitrary:
my-home/src/actor/network.rs#L218
warning: the type of the `self` parameter does not need to be arbitrary
--> my-home/src/actor/network.rs:218:26
|
218 | async fn send<I>(self: &mut Self, item: (I, SocketAddr)) -> Result<(), C::Error>
| ^^^^^^^^^^^^^^^ help: consider to change this parameter to: `&mut self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type
= note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default
|
|
unneeded unit return type:
my-home/src/actor/timer.rs#L37
warning: unneeded unit return type
--> my-home/src/actor/timer.rs:37:27
|
37 | send: Box<dyn Fn() -> () + Send>,
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
|
|
unneeded unit return type:
my-home/src/actor/timer.rs#L42
warning: unneeded unit return type
--> my-home/src/actor/timer.rs:42:27
|
42 | send: Box<dyn Fn() -> () + Send>,
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
|
|
redundant field names in struct initialization:
my-home/src/lifx.rs#L307
warning: redundant field names in struct initialization
--> my-home/src/lifx.rs:307:17
|
307 | source: source,
| ^^^^^^^^^^^^^^ help: replace it with: `source`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|