From 3d4734a9bc91ab226c95a8cce9116fab807fb410 Mon Sep 17 00:00:00 2001 From: Roy Date: Fri, 6 Apr 2018 11:20:49 +0200 Subject: [PATCH 1/2] in-canvas-for-x width:auto instead of width:inherit Issue fix. Discussion can be found https://github.com/zurb/foundation-sites/issues/11124 --- scss/components/_off-canvas.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/components/_off-canvas.scss b/scss/components/_off-canvas.scss index 03a12155d0..bbee8cb27f 100644 --- a/scss/components/_off-canvas.scss +++ b/scss/components/_off-canvas.scss @@ -417,7 +417,7 @@ $breakpoint: small height: auto; position: static; background: inherit; - width: inherit; + width: auto; overflow: inherit; transition: inherit; From ca1848990dd9ef227d6dff2155aa8792bb4c8c81 Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Wed, 11 Apr 2018 22:10:39 +0200 Subject: [PATCH 2/2] fix: reset all OffCanvas properties when in in-canvas mode > Done some research. The incanvas feature always used `inherit`, without explicit reasons given. Most font properties should inherit but not `background`, `width`, `overflow`, `transition` as this is not their default value. I'll replace all of them. See https://github.com/zurb/foundation-sites/pull/11141#discussion_r180879166 --- scss/components/_off-canvas.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scss/components/_off-canvas.scss b/scss/components/_off-canvas.scss index bbee8cb27f..120976517d 100644 --- a/scss/components/_off-canvas.scss +++ b/scss/components/_off-canvas.scss @@ -416,10 +416,10 @@ $breakpoint: small visibility: visible; height: auto; position: static; - background: inherit; + background: none; width: auto; - overflow: inherit; - transition: inherit; + overflow: visible; + transition: none; // Increase CSS specificity &.position-left,