Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frameless embedding with URL parameter #193

Closed
jhurliman opened this issue Feb 4, 2022 · 5 comments
Closed

Frameless embedding with URL parameter #193

jhurliman opened this issue Feb 4, 2022 · 5 comments
Labels
feature A new feature or idea

Comments

@jhurliman
Copy link

jhurliman commented Feb 4, 2022

Use case: I would like to embed Studio in a blog post on https://foxglove.dev/blog to interactively visualize something I am talking about, such as markers in a 3D panel. To accomplish this, I am thinking about an iframe pointed to a URL of the form:

https://studio.foxglove.dev/?layout_url=...&data_source=...&panel_id=...

~~Where panel_id uniquely references one of the panels that appears in the layout loaded from layout_url (a remote JSON file). ~~

EDIT:

https://studio.foxglove.dev/?layout_url=...&data_source=...&frameless=true

I would expect this to strip away most of the UI in Studio: the sidebar, and widgets for adding/removing panels or modifying the current panels.

@jhurliman jhurliman added the feature A new feature or idea label Feb 4, 2022
@jtbandes
Copy link
Member

jtbandes commented Feb 4, 2022

What about just making a "frameless" mode, so the user would create a layout that has a single panel and enable frameless mode to achieve the same thing? Extracting and rendering one panel from a layout seems a bit complicated.

@jhurliman
Copy link
Author

@jtbandes you're right, I was overthinking it. frameless=true plus a single panel layout would be fine.

@jhurliman jhurliman changed the title Single-panel embedding with URL parameter Frameless embedding with URL parameter Feb 4, 2022
@amacneil
Copy link
Contributor

amacneil commented Feb 4, 2022

maybe avoid a double negative? e.g. frame=false or chrome=false... latter is more accurate but maybe confusing with the web browser of the same name.

@jtbandes
Copy link
Member

jtbandes commented Feb 4, 2022

I think frameless is fine, it's kind of a common term, whereas "framed" or "frameful" is not.

@defunctzombie
Copy link

Something to consider - we might want to do this on a different domain than studio.foxglove.dev. Typically it is bad form from a security perspective to allow your site with a user's credentials to be embedded in another site. In fact we plan to dis-allow embedding studio.foxglove.dev for this reason.

@amacneil amacneil transferred this issue from another repository Dec 16, 2022
@foxglove foxglove locked and limited conversation to collaborators Dec 16, 2022
@amacneil amacneil converted this issue into discussion #218 Dec 16, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature A new feature or idea
Development

No branches or pull requests

4 participants