Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: performance regression on RisingWave with 0.11 #708

Closed
MrCroxx opened this issue Sep 13, 2024 · 8 comments · Fixed by #717
Closed

perf: performance regression on RisingWave with 0.11 #708

MrCroxx opened this issue Sep 13, 2024 · 8 comments · Fixed by #717
Assignees
Labels
bug Something isn't working p0 Priority class 0 perf Performance optimization
Milestone

Comments

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 13, 2024

@MrCroxx MrCroxx added bug Something isn't working perf Performance optimization p0 Priority class 0 labels Sep 13, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 13, 2024
@MrCroxx MrCroxx self-assigned this Sep 13, 2024
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 13, 2024

image

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 13, 2024

image

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 13, 2024

image

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 13, 2024

Seems the memory buffer overhead in foyer 0.11 caused heavier operator memory eviction in RW.

@Li0k
Copy link
Collaborator

Li0k commented Sep 13, 2024

Seems the memory buffer overhead in foyer 0.11 caused heavier operator memory eviction in RW.

Can you share the memory consumption metrics from the foyer side ?

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 13, 2024

Seems the memory buffer overhead in foyer 0.11 caused heavier operator memory eviction in RW.

Can you share the memory consumption metrics from the foyer side ?

Actually, I don't think there is a metrics showing it. It is caused by a temporary buffer that was introduced in 0.11. I'm trying to remove it when there is no compression needs.

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 19, 2024

image

Based on the memory prof. The IoBufferPool is the murderer.

collapsed.zip

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Sep 20, 2024

Solved. The regression is caused by the misleading argument buffer_threshold in v0.11. I'll rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 Priority class 0 perf Performance optimization
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants