Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datums and Redeemers should be removed from the SCLogic trait` #115

Open
MitchTurner opened this issue Mar 21, 2023 · 0 comments
Open

Datums and Redeemers should be removed from the SCLogic trait` #115

MitchTurner opened this issue Mar 21, 2023 · 0 comments

Comments

@MitchTurner
Copy link
Collaborator

MitchTurner commented Mar 21, 2023

Currently SCLogic includes the associated types:

    type Endpoints: Send + Sync;
    type Lookups: Send + Sync;
    type LookupResponses: Send + Sync;
    type Datums: Clone + Eq + Debug + Send + Sync;
    type Redeemers: Clone + PartialEq + Eq + Hash + Send + Sync;

This was meant to constrain the LedgerClient to be able to handle the correct Datums and Redeemers. This might not be necessary anymore, now that we have a domain concept of PlutusData and conversions between.

It might be better to put the conversion constraint at the implementation level if you want the conversion guarantees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant