Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address implcity wants valid address #88

Open
MitchTurner opened this issue Jan 19, 2023 · 0 comments
Open

Address implcity wants valid address #88

MitchTurner opened this issue Jan 19, 2023 · 0 comments

Comments

@MitchTurner
Copy link
Collaborator

This is confusing, so maybe we just bite the bullet and force all addresses to be valid. It's just been nice to put Address::new("alice") into tests and not have to think about it being correct. But since some of our impls take a dep on Address and do in fact expect a certain shape, we kinda need to do something. Specifically, the test clients are affected. The live clients kinda force you into us real addresses, whereas in the test code, it'll just give you weird errors when it tries to convert into bytes and stuff.

We can do better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant