Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gaps in the MovingWindow data #213

Closed
matthias-wende-frequenz opened this issue Feb 21, 2023 · 4 comments
Closed

Handle gaps in the MovingWindow data #213

matthias-wende-frequenz opened this issue Feb 21, 2023 · 4 comments
Assignees
Milestone

Comments

@matthias-wende-frequenz
Copy link
Contributor

matthias-wende-frequenz commented Feb 21, 2023

Provide an interface for handling gaps

  • the user should be able to tell what to do with gaps, e.g. replace with constant number, bfill ffill, interpolate
  • should be able to get a list of all gaps

Accessing behavior of uninitialized or missing data

We need to check if data is potentially uninitialized in the __getitem__
method and define what to do in that case.
The check can be performed by using the ringbuffers gaps. Thus we'd need to
check if the requested data subwindow intersects with any interval stored as gap.

possible actions when uninitialized data is accessed:

  • raise an exception
  • return the biggest subset
@Marenz
Copy link
Contributor

Marenz commented Jun 16, 2023

Gaps here refers to the gaps found in the OrderedRingBuffer class and how they can be handled

@matthias-wende-frequenz
Copy link
Contributor Author

@cwasicki can we close this issue?

@cwasicki
Copy link
Collaborator

Do you remember who requested these features?

the user should be able to tell what to do with gaps, e.g. replace with constant number,

This is available now.

bfill ffill, interpolate

This is not supported but could be done by the user on the array.

should be able to get a list of all gaps

This request was just closed: #558

@matthias-wende-frequenz
Copy link
Contributor Author

Do you remember who requested these features?

I can't remember but might come from myself :). I'll close the issue now.

@llucax llucax closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@llucax llucax modified the milestones: post-v1.0, v1.0.0-rc2 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dropped
Development

No branches or pull requests

5 participants