Fix PV power distribution #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To exclude PV inverters that didn't send any data. The power distributor crashes because it tried to get data from a component that didn't send any data since the application startup. Signed-off-by: Elzbieta Kotulska <elzbieta.kotulska@frequenz.com>
github-actions
bot
added
part:docs
daniel-zullo-frequenz
requested review from
ela-kotulska-frequenz and
tiyash-basu-frequenz
ela-kotulska-frequenz
previously approved these changes
Jul 31, 2024
If desired power is already reached without the need to use some inverters, their powers need to be set to zero. If not, their original powers would remain and the target powers would be wrong. In case the requested power is zero, this was also leading to crashes because there were no allocations. This change also fixes that issue. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
daniel-zullo-frequenz
dismissed
ela-kotulska-frequenz’s stale review
via
894fcf2
github-actions
bot
added
the
part:tests
ela-kotulska-frequenz
approved these changes
Jul 31, 2024
daniel-zullo-frequenz
merged commit c9115e0
into
frequenz-floss:v1.0.0-rc6xx
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To exclude PV inverters that didn't send any data. The power distributor crashes because it tried to get data from a component that didn't send any data since the application startup.