Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1.0.0-rc6xx into v1.x.x #1042

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 21, 2024

This pulls one bug fix from rc6xx that weren't ported to v1.x.x:

  • Fix gap in ring buffer when updating a missing value

We merge the branches anyway to make it perfectly clear and obvious that now all changes in 6xx were incorporated to v1.x.x.

ela-kotulska-frequenz and others added 9 commits July 31, 2024 22:12
To exclude PV inverters that didn't send any data.
The power distributor crashes because it tried to get
data from a component that didn't send any data since
the application startup.

Signed-off-by: Elzbieta Kotulska <elzbieta.kotulska@frequenz.com>
If desired power is already reached without the need to use some
inverters, their powers need to be set to zero.

If not, their original powers would remain and the target powers would
be wrong.

In case the requested power is zero, this was also leading to crashes
because there were no allocations.  This change also fixes that issue.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
To exclude PV inverters that didn't send any data. The power distributor
crashes because it tried to get data from a component that didn't send
any data since the application startup.
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
If there are no gaps in the ring buffer and the new value is missing
and creates a gap in time, we need to start the new gap after the
latest value from before.

Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
)

If there are no gaps in the ring buffer and the new value is missing and
creates a gap in time, we need to start the new gap after the latest
value from before.

Fixes frequenz-floss#646.
`Task.exception()` returns raised exceptions as values, unless tasks
raised `CancelledError`, in which case, `Task.exception()` raises
`CancelledError` as well:
https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.exception

`Task.result()` provides a more consistent interface, by always
re-raising all caught exceptions.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@llucax llucax requested a review from a team as a code owner August 21, 2024 06:49
@llucax llucax requested review from shsms and removed request for a team August 21, 2024 06:49
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid labels Aug 21, 2024
@llucax llucax added this to the v1.0.0-rc800 milestone Aug 21, 2024
@llucax llucax force-pushed the merge-rc6xx branch 2 times, most recently from c908250 to c36a8ea Compare August 21, 2024 06:53
@llucax llucax self-assigned this Aug 21, 2024
@llucax llucax added the type:bug Something isn't working label Aug 21, 2024
@llucax llucax enabled auto-merge August 21, 2024 07:02
@llucax
Copy link
Contributor Author

llucax commented Aug 21, 2024

Oh, it seems we have more issues with mkdocs that will not be trivial to fix. So I will pull those fixes to a separate branch and see how we deal with them separately so we don't block this (and other) PR(s). We'll have to force-merge until this is fixed.

@llucax
Copy link
Contributor Author

llucax commented Aug 21, 2024

Needs a rebase on top of #1043 to fix the CI.

# By Sahas Subramanian (3) and others
# Via GitHub (3) and Sahas Subramanian (1)
* upstream/v1.0.0-rc6xx:
  Update release notes
  Replace `Task.exception()` with `Task.result()`
  Fix gap in ring buffer when updating a missing value
  Clear release notes
  Set zero power for PV inverters not neccessary to reach target power
  Fix PV power distribution
@llucax llucax added this pull request to the merge queue Aug 21, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit fd2572e Aug 21, 2024
18 checks passed
@llucax llucax deleted the merge-rc6xx branch August 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests type:bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

5 participants